Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ic js with latest governance #3015

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Upgrade ic js with latest governance #3015

merged 7 commits into from
Aug 2, 2023

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Aug 2, 2023 •
edited
Loading

Motivation

Upgrade ic-js to get latest fields for 1-proposal.
Related to dfinity/ic-js#389

Changes

  • upgrade ic-js to latest next
  • set new flag to false

Tests

Manually tested that the new field is visible.
image

Todos

  • Add entry to changelog (if necessary).

peterpeterparker
peterpeterparker approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mstrasinskis mstrasinskis added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit e7713c1 Aug 2, 2023
35 checks passed
@mstrasinskis mstrasinskis deleted the upgrade-ic-js branch August 2, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

@lmuntaner lmuntaner Awaiting requested review from lmuntaner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @peterpeterparker