compiler: Remove counters from subdomains and automatically generate unique names #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2431 +/- ##
==========================================
+ Coverage 87.01% 87.07% +0.06%
==========================================
Files 239 239
Lines 44958 45048 +90
Branches 8390 8412 +22
==========================================
+ Hits 39118 39224 +106
+ Misses 5108 5093 -15
+ Partials 732 731 -1 ☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
reviewed
Jul 31, 2024
mloubout
reviewed
Jul 31, 2024
mloubout
reviewed
Jul 31, 2024
This was referenced Aug 1, 2024
mloubout
reviewed
Aug 6, 2024
EdCaunt
force-pushed
the
counters_redux
branch
from
09a44e0
to
4f6d84b
Compare
mloubout
reviewed
Sep 13, 2024
mloubout
approved these changes
Sep 13, 2024
EdCaunt
force-pushed
the
counters_redux
branch
2 times, most recently
from
4f18c77
to
de56705
Compare
…ue to need for unique hashes
EdCaunt
force-pushed
the
counters_redux
branch
from
de56705
to
1297db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using counters to ensure subdimensions etc are unique, they should be dynamically renamed during compilation.
Supersedes #2405 .