dsl: Fix missing sympy assumptions during rebuilding #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2436 +/- ##
==========================================
+ Coverage 87.00% 87.01% +0.01%
==========================================
Files 236 236
Lines 44851 44899 +48
Branches 8362 8363 +1
==========================================
+ Hits 39021 39069 +48
Misses 5101 5101
Partials 729 729 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Aug 1, 2024
mloubout
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymPy assumptions currently disappear when objects inheriting from
sympy.Symbolare rebuilt. This PR adds a patch and tests.#2431 needs rebasing on this patch.