Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add microphone_connect action #1537

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Sep 15, 2024

To be merged after #1536.

@dermotduffy
Copy link
Owner

I'm not sure if this will work in the normal case, as connecting the microphone is obviously a highly sensitive action (unlike disconnecting). I am guessing the browser would reject this?

@felipecrs felipecrs marked this pull request as ready for review September 15, 2024 22:56
@felipecrs
Copy link
Contributor Author

felipecrs commented Sep 15, 2024

I'm not sure if this will work in the normal case, as connecting the microphone is obviously a highly sensitive action (unlike disconnecting). I am guessing the browser would reject this?

Hm... for what I was wondering, it is working fine. I used it in the green call button demonstrated in: #1536 (comment)

Maybe however it would not work as a URL query parameter (I did not test). Is that what you meant?

@dermotduffy
Copy link
Owner

Hm... for what I was wondering, it is working fine. I used it in the green call button demonstrated in: #1536 (comment)

Actual, on thinking about it, worst case the browser would just use ask the user as usual.

Ready for me to look at this one?

@felipecrs
Copy link
Contributor Author

Actual, on thinking about it, worst case the browser would just use ask the user as usual.

That's correct. Anyway, this is certainly less sensitive than microphone_unmute (which causes connect as well), which is already implemented and work well.

Ready for me to look at this one?

Yes, please. Very straightforward implementation thanks to your instructions.

@dermotduffy dermotduffy merged commit af4666e into dermotduffy:main Sep 16, 2024
2 checks passed
@dermotduffy
Copy link
Owner

Thanks @felipecrs !

@dermotduffy dermotduffy added the feature New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants