-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add microphone_connect
action
#1537
Conversation
I'm not sure if this will work in the normal case, as connecting the microphone is obviously a highly sensitive action (unlike disconnecting). I am guessing the browser would reject this? |
9cf2879
to
bf23acd
Compare
Hm... for what I was wondering, it is working fine. I used it in the green call button demonstrated in: #1536 (comment) Maybe however it would not work as a URL query parameter (I did not test). Is that what you meant? |
Actual, on thinking about it, worst case the browser would just use ask the user as usual. Ready for me to look at this one? |
That's correct. Anyway, this is certainly less sensitive than
Yes, please. Very straightforward implementation thanks to your instructions. |
bf23acd
to
ed375ec
Compare
Thanks @felipecrs ! |
To be merged after #1536.