Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PECO-1760] Certifi removes GLOBALTRUST root certificate #410

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[PECO-1760] Certifi removes GLOBALTRUST root certificate #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e792de0
Bumped up the version of certifi to 2024.7.4
jprakash-db Jul 8, 2024
3a3ebb1
Removed uneccessary files
jprakash-db Jul 8, 2024
a227031
Fixed merge conflicts
jprakash-db Jul 8, 2024
8ac9b89
Updated the poetry.lock files
jprakash-db Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ sqlalchemy = { version = ">=2.0.21", optional = true }
openpyxl = "^3.0.10"
alembic = { version = "^1.0.11", optional = true }
urllib3 = ">=1.26"
certifi = "2024.7.4"
Copy link
Collaborator

@kravets-levko kravets-levko Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so I checked where this dependency come from. It is a transitive dependency of requests package. Also, I checked the requests itself - its latest version also uses old certifi. So I think in this case it's okay to add a consraint to our project and wait for requests upgrade. Two more things to do:

  1. add a comment that once requests updates certifi to the version that will satisfy us - we should roll this change back and upgrae `requests instead
  2. also, instead of pinning the exact version - better relax the constraint a bit (e.g. "^2024.7.4")


[tool.poetry.extras]
sqlalchemy = ["sqlalchemy"]
Expand Down
Loading