[PECO-1760] Certifi removes GLOBALTRUST root certificate #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprakash-db
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db,
benc-db and
kravets-levko
as code owners
kravets-levko
requested changes
Jul 8, 2024
There was a problem hiding this comment.
@jprakash-db Dependency upgrade looks good 👍 But please remove the .idea folder from the PR. Also, what are that two files in src/databricks/sqlalchemy/test/? Are they relevant to this PR?
kravets-levko
changed the title
|
@kravets-levko Fixed the issues |
kravets-levko
requested changes
Jul 8, 2024
| @@ -27,6 +27,7 @@ sqlalchemy = { version = ">=2.0.21", optional = true } | |||
| openpyxl = "^3.0.10" | |||
| alembic = { version = "^1.0.11", optional = true } | |||
| urllib3 = ">=1.26" | |||
| certifi = "2024.7.4" | |||
There was a problem hiding this comment.
Okay, so I checked where this dependency come from. It is a transitive dependency of requests package. Also, I checked the requests itself - its latest version also uses old certifi. So I think in this case it's okay to add a consraint to our project and wait for requests upgrade. Two more things to do:
- add a comment that once
requestsupdatescertifito the version that will satisfy us - we should roll this change back and upgrae `requests instead - also, instead of pinning the exact version - better relax the constraint a bit (e.g. "^2024.7.4")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the certify version to "2024.7.4"
Dependabot report:
Certifi 2024.07.04 removes root certificates from "GLOBALTRUST" from the root store. These are in the process of being removed from Mozilla's trust store.
GLOBALTRUST's root certificates are being removed pursuant to an investigation which identified "long-running and unresolved compliance issues". Conclusions of Mozilla's investigation can be found here.