-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor how Questionnaires are generated during the $apply operation #505
base: master
Are you sure you want to change the base?
Conversation
Formatting check succeeded! |
3d89e07
to
a9a65a8
Compare
bccea4b
to
5b1495b
Compare
758811a
to
8e436c3
Compare
cqf-fhir-cr/src/main/java/org/opencds/cqf/fhir/cr/visitor/DataRequirementsVisitor.java
Show resolved
Hide resolved
.anyMatch(lc -> lc.getExtension().stream() | ||
.map(c -> (IBaseExtension<?, ?>) c) | ||
.anyMatch(c -> c.getUrl().equals("name") | ||
&& resolvePathString(c.getValue(), "code") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential NPE if code = null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! Thank's for catching that!
Quality Gate passedIssues Measures |
decent handful of issues flagged, don't see anything majorly critical, but I'd have a look through https://sonarcloud.io/project/issues?id=cqframework_clinical-reasoning&pullRequest=505&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true before merging |
Closes #472
Closes #481
Closes #482