Skip to content

Commit

Permalink
Add tests for InputParameterResolver
Browse files Browse the repository at this point in the history
  • Loading branch information
barhodes committed Sep 3, 2024
1 parent 3ebf962 commit a9a65a8
Show file tree
Hide file tree
Showing 10 changed files with 209 additions and 65 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import ca.uhn.fhir.context.FhirContext;
import java.util.List;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -53,12 +53,12 @@ protected FhirContext fhirContext() {

protected <R extends IBaseResource> R readRepository(Class<R> resourceType, IIdType id) {
try {
return repository.read(resourceType, id, null);
return repository.read(resourceType, id);
} catch (Exception e) {
return null;
}
}

protected abstract IBaseParameters resolveParameters(
IBaseParameters parameters, List<IBaseBackboneElement> context, List<IBaseExtension<?, ?>> launchContext);
IBaseParameters parameters, List<IBase> context, List<IBaseExtension<?, ?>> launchContext);
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import static com.google.common.base.Preconditions.checkNotNull;

import java.util.List;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -37,7 +37,7 @@ public static <T extends IInputParameterResolver> T createResolver(
IBaseParameters parameters,
boolean useServerData,
IBaseBundle data,
List<IBaseBackboneElement> context,
List<IBase> context,
List<IBaseExtension<?, ?>> launchContext) {
checkNotNull(repository, "expected non-null value for repository");
var fhirVersion = repository.fhirContext().getVersion().getVersion();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import org.hl7.fhir.dstu3.model.Practitioner;
import org.hl7.fhir.dstu3.model.Resource;
import org.hl7.fhir.dstu3.model.ValueSet;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -43,17 +43,15 @@ public InputParameterResolver(
IBaseParameters parameters,
boolean useServerData,
IBaseBundle data,
List<IBaseBackboneElement> context,
List<IBase> context,
List<IBaseExtension<?, ?>> launchContext) {
super(repository, subjectId, encounterId, practitionerId, parameters, useServerData, data);
this.parameters = resolveParameters(parameters, context, launchContext);
}

@Override
protected final Parameters resolveParameters(
IBaseParameters baseParameters,
List<IBaseBackboneElement> context,
List<IBaseExtension<?, ?>> launchContext) {
IBaseParameters baseParameters, List<IBase> context, List<IBaseExtension<?, ?>> launchContext) {
var params = parameters();
if (baseParameters != null) {
params.getParameter().addAll(((Parameters) baseParameters).getParameter());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -52,17 +52,15 @@ public InputParameterResolver(
IBaseParameters parameters,
boolean useServerData,
IBaseBundle data,
List<IBaseBackboneElement> context,
List<IBase> context,
List<IBaseExtension<?, ?>> launchContext) {
super(repository, subjectId, encounterId, practitionerId, parameters, useServerData, data);
this.parameters = resolveParameters(parameters, context, launchContext);
}

@Override
protected final Parameters resolveParameters(
IBaseParameters baseParameters,
List<IBaseBackboneElement> context,
List<IBaseExtension<?, ?>> launchContext) {
IBaseParameters baseParameters, List<IBase> context, List<IBaseExtension<?, ?>> launchContext) {
var params = parameters();
if (baseParameters != null) {
params.getParameter().addAll(((Parameters) baseParameters).getParameter());
Expand Down Expand Up @@ -111,7 +109,7 @@ protected boolean validateContext(String name, String type) {
}

protected void resolveLaunchContext(
Parameters params, List<IBaseBackboneElement> contexts, List<IBaseExtension<?, ?>> launchContexts) {
Parameters params, List<IBase> contexts, List<IBaseExtension<?, ?>> launchContexts) {
final List<String> validContexts = Arrays.asList("patient", "encounter", "location", "user", "study");
if (launchContexts != null && !launchContexts.isEmpty()) {
launchContexts.stream().map(e -> (Extension) e).forEach(launchContext -> {
Expand Down Expand Up @@ -146,6 +144,7 @@ protected void resolveLaunchContext(
.map(p -> readRepository(
fhirContext().getResourceDefinition(type).getImplementingClass(),
((Reference) p.getValue()).getReferenceElement()))
.filter(p -> p != null)
.collect(Collectors.toList());
if (!value.isEmpty()) {
var resource =
Expand All @@ -155,6 +154,9 @@ protected void resolveLaunchContext(
((Bundle) resource).addEntry(new BundleEntryComponent().setResource((Resource) v)));
}
params.addParameter(part("%" + name, resource));
} else {
throw new IllegalArgumentException(
String.format("Unable to retrieve resource for context: %s", name));
}
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -52,17 +52,15 @@ public InputParameterResolver(
IBaseParameters parameters,
boolean useServerData,
IBaseBundle data,
List<IBaseBackboneElement> context,
List<IBase> context,
List<IBaseExtension<?, ?>> launchContext) {
super(repository, subjectId, encounterId, practitionerId, parameters, useServerData, data);
this.parameters = resolveParameters(parameters, context, launchContext);
}

@Override
protected final Parameters resolveParameters(
IBaseParameters baseParameters,
List<IBaseBackboneElement> context,
List<IBaseExtension<?, ?>> launchContext) {
IBaseParameters baseParameters, List<IBase> context, List<IBaseExtension<?, ?>> launchContext) {
var params = parameters();
if (baseParameters != null) {
params.getParameter().addAll(((Parameters) baseParameters).getParameter());
Expand Down Expand Up @@ -111,7 +109,7 @@ protected boolean validateContext(String name, String type) {
}

protected void resolveLaunchContext(
Parameters params, List<IBaseBackboneElement> contexts, List<IBaseExtension<?, ?>> launchContexts) {
Parameters params, List<IBase> contexts, List<IBaseExtension<?, ?>> launchContexts) {
final List<String> validContexts = Arrays.asList("patient", "encounter", "location", "user", "study");
if (launchContexts != null && !launchContexts.isEmpty()) {
launchContexts.stream().map(e -> (Extension) e).forEach(launchContext -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import ca.uhn.fhir.context.FhirVersionEnum;
import java.util.List;
import org.apache.commons.lang3.StringUtils;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseParameters;
Expand Down Expand Up @@ -204,7 +204,7 @@ public PopulateRequest buildPopulateRequest(
String operationName,
IBaseResource questionnaire,
String subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand All @@ -229,7 +229,7 @@ public PopulateRequest buildPopulateRequest(
public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource populate(
Either3<C, IIdType, R> questionnaire,
String subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand All @@ -253,7 +253,7 @@ public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource
public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource populate(
Either3<C, IIdType, R> questionnaire,
String subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand All @@ -276,7 +276,7 @@ public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource
public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource populate(
Either3<C, IIdType, R> questionnaire,
String subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand All @@ -296,7 +296,7 @@ public <C extends IPrimitiveType<String>, R extends IBaseResource> IBaseResource
public IBaseResource populate(
IBaseResource questionnaire,
String subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import ca.uhn.fhir.context.FhirVersionEnum;
import java.util.List;
import org.hl7.fhir.dstu3.model.Reference;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBundle;
import org.hl7.fhir.instance.model.api.IBaseExtension;
import org.hl7.fhir.instance.model.api.IBaseOperationOutcome;
Expand All @@ -23,7 +23,7 @@ public class PopulateRequest implements IQuestionnaireRequest {
private final String operationName;
private final IBaseResource questionnaire;
private final IIdType subjectId;
private final List<IBaseBackboneElement> context;
private final List<IBase> context;
private final List<IBaseExtension<?, ?>> launchContext;
private final IBaseParameters parameters;
private final IBaseBundle data;
Expand All @@ -39,7 +39,7 @@ public PopulateRequest(
String operationName,
IBaseResource questionnaire,
IIdType subjectId,
List<IBaseBackboneElement> context,
List<IBase> context,
IBaseExtension<?, ?> launchContext,
IBaseParameters parameters,
IBaseBundle data,
Expand Down Expand Up @@ -149,7 +149,7 @@ protected final String resolveDefaultLibraryUrl() {
: ((IPrimitiveType<String>) libraryExt.getValue()).getValue();
}

public List<IBaseBackboneElement> getContext() {
public List<IBase> getContext() {
return context;
}

Expand Down
Loading

0 comments on commit a9a65a8

Please sign in to comment.