Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: Implemented withParam, separated container creation from run_container function #227

Closed
wants to merge 35 commits into from
Closed

[WIP] feat: Implemented withParam, separated container creation from run_container function #227

wants to merge 35 commits into from

Commits on Jun 15, 2021

  1. submitter now saves default client configuration

    @moshewe
    moshewe committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d1196d5 View commit details
    Browse the repository at this point in the history

  2. submitter setting client configuration as default

    orelmosheweinstock committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    c29c9be View commit details
    Browse the repository at this point in the history

  3. submitter setting client configuration as default

    orelmosheweinstock committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    58e5f92 View commit details
    Browse the repository at this point in the history

  4. submitter setting client configuration as default

    @moshewe
    moshewe committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d8b49f1 View commit details
    Browse the repository at this point in the history

  5. implemented a simplified version of env_from

    @moshewe
    moshewe committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    37ea72a View commit details
    Browse the repository at this point in the history

  6. implemented a default name salter to avoid duplicate names when submi… 

    …tting multiple workflows with the same use-case
    @moshewe
    moshewe committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    58cd505 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. implemented default submitter 

    created a method for configuring couler general defaults
implemented `parallelism` for `Countaine`s
    @moshewe
    moshewe committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    f3a5a16 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. fixed access to default submitter

    @moshewe
    moshewe committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c62b03c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. removed unneeded comments, run pre-commit

    @moshewe
    moshewe committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    fde0327 View commit details
    Browse the repository at this point in the history

  2. added usage example for default submitter

    @moshewe
    moshewe committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f7dc861 View commit details
    Browse the repository at this point in the history

  3. forgot to add dependency strgen

    @moshewe
    moshewe committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    e544263 View commit details
    Browse the repository at this point in the history

  4. forgot to add dependency stringcase

    @moshewe
    moshewe committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    9a07d15 View commit details
    Browse the repository at this point in the history

  5. fixed unit tests by turning off name salter

    @moshewe
    moshewe committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    dd22b75 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. fixed StringGenerator requirement

    @moshewe
    moshewe committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    514652f View commit details
    Browse the repository at this point in the history

  2. added test to make sure workflow name salting mechanism works

    @moshewe
    moshewe committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    dfd6be5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. added stringcase (was removed by mistake)

    @moshewe
    moshewe committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    e43711d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'couler-proj:master' into master

    @moshewe
    moshewe committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    bed7be0 View commit details
    Browse the repository at this point in the history

  3. comment on salted name length

    @moshewe
    moshewe committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    c096610 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. changed privacy of certain variables, more readable default submitter… 

    … example
    @moshewe
    moshewe committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c5f81eb View commit details
    Browse the repository at this point in the history

  2. moved default argo submitter setting to main argo import

    @moshewe
    moshewe committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f7c57d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. sanity checks reformatting

    @moshewe
    moshewe committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    56634d1 View commit details
    Browse the repository at this point in the history

  2. creating artifacts seperate from run_x 

    allowed naming artifacts and parameters
implemented withParam
need to fix parallelism
    @moshewe
    moshewe committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4daf6eb View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. can now add explicit name to artifacts 

    removed parallelism from template (not in argo spec)
added parallelism to Step/DAG task
    @moshewe
    moshewe committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    3afdc8e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. artifacts can now be named! 

    using ArgumentParameter and InputParameter to go around old conventions without disrupting them
    @moshewe
    moshewe committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    696164d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. artifacts can now be named! 

    using ArgumentParameter and InputParameter to go around old conventions without disrupting them
    @moshewe
    moshewe committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    17ce107 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Merge branch 'master' into with-param

    @moshewe
    moshewe committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    5845e45 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. added support for {archive: {"none":{}}} field + value in artifacts. 

    added suffix to split by user
added workflow labels
    @moshewe
    moshewe committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    3169dd2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. implemented tolerations for containers 

    added some more attr.s for great justice
    @moshewe
    moshewe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    5e09c0f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/with-param' into with-param 

    # Conflicts:
#	couler/core/run_templates.py
#	couler/core/templates/container.py
#	couler/core/templates/template.py
    @moshewe
    moshewe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    af9bb66 View commit details
    Browse the repository at this point in the history

  3. added tolerations to learning container

    @moshewe
    moshewe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    cebc63d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. container output is now a dict! 

    outputs refactored to use attrs, now have common value and placeholder functionality
step/task now puts withParam placeholder
step_update_utils.py OutputArtifact handling greatly simplified using OutputArtifact fields
    @moshewe
    moshewe committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    bc575e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. script didn't use new convention

    @moshewe
    moshewe committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    7d56899 View commit details
    Browse the repository at this point in the history

  2. formatting

    @moshewe
    moshewe committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    55008f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. extract step return patched

    @moshewe
    moshewe committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    d089809 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. implemented env_from for scripts

    @moshewe
    moshewe committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    057ffc6 View commit details
    Browse the repository at this point in the history