[WIP] feat: Implemented withParam, separated container creation from run_container function
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting multiple workflows with the same use-case
created a method for configuring couler general defaults implemented `parallelism` for `Countaine`s
allowed naming artifacts and parameters implemented withParam need to fix parallelism
removed parallelism from template (not in argo spec) added parallelism to Step/DAG task
using ArgumentParameter and InputParameter to go around old conventions without disrupting them
using ArgumentParameter and InputParameter to go around old conventions without disrupting them
moshewe
changed the title
withParam, separated container creation from run_container functionwithParam, separated container creation from run_container function
moshewe
changed the title
withParam, separated container creation from run_container functionwithParam, separated container creation from run_container function
moshewe
changed the title
withParam, separated container creation from run_container functionwithParam, separated container creation from run_container function
added suffix to split by user added workflow labels
added some more attr.s for great justice
# Conflicts: # couler/core/run_templates.py # couler/core/templates/container.py # couler/core/templates/template.py
outputs refactored to use attrs, now have common value and placeholder functionality step/task now puts withParam placeholder step_update_utils.py OutputArtifact handling greatly simplified using OutputArtifact fields
moshewe
changed the title
withParam, separated container creation from run_container functionwithParam, separated container creation from run_container function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issues #220 , #224
Why are the changes needed?
Does this PR introduce any user-facing change?
Added
create_parameter_artifactandcreate_container_templateto maincoulerinterface.How was this patch tested?
still requires unit tests, currently tested with live code