Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdlib.sh: add env var to sleep before killing tail #3792

Merged
merged 1 commit into from
May 6, 2024

Commits on May 6, 2024

  1. cmdlib.sh: add env var to sleep before killing tail

    I can't reproduce this locally, but I have a suspicion that `tail` can
    exit too quickly in some circumstances, causing truncated output:
    
    openshift/os#1498 (comment)
    coreos#3785 (comment)
    
    Rather than having an unconditional `sleep`, let's make it easier to
    test that theory by having an env var we can use to make it optional.
    Then we'll test that in CI.
    
    Mid-term, I'd like to revert 79b15c8 soon so we can go back to
    virtio-serial which is just so much cleaner.
    jlebon committed May 6, 2024
    Configuration menu
    Copy the full SHA
    990a0a7 View commit details
    Browse the repository at this point in the history