cmdlib.sh: add env var to sleep before killing tail
#3792
Conversation
I can't reproduce this locally, but I have a suspicion that `tail` can exit too quickly in some circumstances, causing truncated output: openshift/os#1498 (comment) coreos#3785 (comment) Rather than having an unconditional `sleep`, let's make it easier to test that theory by having an env var we can use to make it optional. Then we'll test that in CI. Mid-term, I'd like to revert 79b15c8 soon so we can go back to virtio-serial which is just so much cleaner.
|
/retest |
1 similar comment
|
/retest |
|
@jlebon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Interesting. Prow is still hitting:
But I did tag it into the continuous tag and the repo was already regenerated. CoreOS CI at least is happy now. That repo isn't mirrored AFAIK though I wonder if Prow is somehow hitting an old version. |
I can't reproduce this locally, but I have a suspicion that
tailcan exit too quickly in some circumstances, causing truncated output:openshift/os#1498 (comment)
#3785 (comment)
Rather than having an unconditional
sleep, let's make it easier to test that theory by having an env var we can use to make it optional. Then we'll test that in CI.Mid-term, I'd like to revert 79b15c8 soon so we can go back to virtio-serial which is just so much cleaner.