Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a comment after a c/storage update #2299

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Feb 15, 2024

This updates for the trivial half of containers/storage#1830.

It does not update to benefit from the more important part (creating the reused layers with the right CompressedDigest/CompressedSize) — that also should happen, but it’s a tiny bit of work and not an immediate priority.

@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2024

Needs a rebase.

Should not change behavior.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac changed the title Update c/storage and a comment about that Update a comment after a c/storage update Feb 19, 2024
@mtrmac
Copy link
Collaborator Author

mtrmac commented Feb 20, 2024

Rebased, now just a comment update.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrothberg vrothberg merged commit f42a082 into containers:main Feb 20, 2024
10 checks passed
@mtrmac mtrmac deleted the PutLayer-improvements branch February 20, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants