Skip to content

Commit

Permalink
Remove a comment about an optimization that now exists in c/storage
Browse files Browse the repository at this point in the history
Should not change behavior.

Signed-off-by: Miloslav Trmač <[email protected]>
  • Loading branch information
mtrmac committed Feb 19, 2024
1 parent dff1269 commit d8b2b98
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions storage/storage_dest.go
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,6 @@ func (s *storageImageDestination) createNewLayer(index int, layerDigest digest.D
// We can legitimately set storage.LayerOptions.OriginalDigest to "",
// but that would just result in PutLayer computing the digest of the input stream == optionalDiffID.
// So, instead, set .OriginalDigest to the value we know already, to avoid that digest computation.
// FIXME? If both trustedUncompressedDigest and trustedOriginalDigest are "", PutLayer currently digests the uncompressed layer
// twice. We could compute the digest here, but fixing that in c/storage would be more general.
trustedOriginalDigest = optionalDiffID

// Allow using the already-collected layer contents without extracting the layer again.
Expand Down

0 comments on commit d8b2b98

Please sign in to comment.