remove useless code and fix typo error

pkg/storage/internalstorage/features.go

@@ -17,7 +17,7 @@ const (
 	// for better defense against SQL injection.
 	//
 	// Use either single whereSQLStatement field, a pair of whereSQLStatement with whereSQLParam, or
-	// whereSQLStatement with whereSQLJSONParams to pass the SQL it self and parameters.
+	// whereSQLStatement with whereSQLJSONParams to pass the SQL itself and parameters.
 	//
 	// owner: @nekomeowww
 	// alpha: v0.8.0

pkg/storage/internalstorage/resource_storage.go

@@ -127,7 +127,7 @@ func (s *ResourceStorage) Update(ctx context.Context, cluster string, obj runtim
 	return InterpretResourceDBError(cluster, metaobj.GetName(), result.Error)
 }
 
-func (c *ResourceStorage) ConvertDeletedObject(obj interface{}) (runtime.Object, error) {
+func (s *ResourceStorage) ConvertDeletedObject(obj interface{}) (runtime.Object, error) {
 	key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
 	if err != nil {
 		return nil, err
@@ -188,7 +188,7 @@ func (s *ResourceStorage) Get(ctx context.Context, cluster, namespace, name stri
 		return err
 	}
 	if obj != into {
-		return fmt.Errorf("Failed to decode resource, into is %T", into)
+		return fmt.Errorf("failed to decode resource, into is %T", into)
 	}
 	return nil
 }

pkg/storage/internalstorage/storage.go

@@ -39,9 +39,9 @@ func (s *StorageFactory) NewCollectionResourceStorage(cr *internal.CollectionRes
 	return nil, fmt.Errorf("not support collection resource: %s", cr.Name)
 }
 
-func (f *StorageFactory) GetResourceVersions(ctx context.Context, cluster string) (map[schema.GroupVersionResource]map[string]interface{}, error) {
+func (s *StorageFactory) GetResourceVersions(ctx context.Context, cluster string) (map[schema.GroupVersionResource]map[string]interface{}, error) {
 	var resources []Resource
-	result := f.db.WithContext(ctx).Select("group", "version", "resource", "namespace", "name", "resource_version").
+	result := s.db.WithContext(ctx).Select("group", "version", "resource", "namespace", "name", "resource_version").
 		Where(map[string]interface{}{"cluster": cluster}).
 		Find(&resources)
 	if result.Error != nil {
@@ -66,8 +66,8 @@ func (f *StorageFactory) GetResourceVersions(ctx context.Context, cluster string
 	return resourceversions, nil
 }
 
-func (f *StorageFactory) CleanCluster(ctx context.Context, cluster string) error {
-	result := f.db.WithContext(ctx).Where(map[string]interface{}{"cluster": cluster}).Delete(&Resource{})
+func (s *StorageFactory) CleanCluster(ctx context.Context, cluster string) error {
+	result := s.db.WithContext(ctx).Where(map[string]interface{}{"cluster": cluster}).Delete(&Resource{})
 	return InterpretDBError(cluster, result.Error)
 }
 

pkg/storage/internalstorage/util.go

@@ -218,7 +218,7 @@ func applyListOptionsToQuery(query *gorm.DB, opts *internal.ListOptions, applyFn
 		query,
 		opts.URLQuery,
 		utilfeature.DefaultMutableFeatureGate.Enabled(AllowRawSQLQuery),
-		utilfeature.DefaultMutableFeatureGate.Enabled((AllowParameterizedSQLQuery)),
+		utilfeature.DefaultMutableFeatureGate.Enabled(AllowParameterizedSQLQuery),
 	)
 	if err != nil {
 		return 0, nil, nil, err

pkg/storage/memorystorage/memory_resource_storage.go

@@ -99,7 +99,7 @@ func (s *ResourceStorage) ConvertDeletedObject(obj interface{}) (runobj runtime.
 	if obj, ok := obj.(runtime.Object); ok {
 		return obj, nil
 	}
-	return nil, fmt.Errorf("Invalid Type(%T): couldn't convert deleted object", obj)
+	return nil, fmt.Errorf("invalid Type(%T): couldn't convert deleted object", obj)
 }
 
 func (s *ResourceStorage) Delete(ctx context.Context, cluster string, obj runtime.Object) error {
@@ -135,7 +135,7 @@ func (s *ResourceStorage) Get(ctx context.Context, cluster, namespace, name stri
 	}
 
 	if obj != into {
-		return fmt.Errorf("Failed to decode resource, into is %T", into)
+		return fmt.Errorf("failed to decode resource, into is %T", into)
 	}
 	return nil
 }

pkg/storage/register.go

@@ -21,7 +21,7 @@ func NewStorageFactory(name, configPath string) (StorageFactory, error) {
 
 	storagefactory, err := provider(configPath)
 	if err != nil {
-		return nil, fmt.Errorf("Failed to init storage: %w", err)
+		return nil, fmt.Errorf("failed to init storage: %w", err)
 	}
 	return storagefactory, nil
 }