remove useless code and fix typo error #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @googs1025, DetailsInstructions for interacting with me using comments are available here. |
clusterpedia-bot
added
the
kind/cleanup
Iceber
reviewed
Feb 18, 2024
| @@ -604,12 +604,12 @@ func buildClusterConfig(cluster *clusterv1alpha2.PediaCluster) (*rest.Config, er | |||
| } | |||
|
|
|||
| if cluster.Spec.APIServer == "" { | |||
| return nil, errors.New("Cluster APIServer Endpoint is required") | |||
| return nil, errors.New("cluster APIServer Endpoint is required") | |||
There was a problem hiding this comment.
Here they are treated as a special whole that can begin with a capitalization.
There was a problem hiding this comment.
ok, I got it, thank you for your review.
There was a problem hiding this comment.
@Iceber Already modified, thanks for reviewing again.
Signed-off-by: googs1025 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
fix some typo error
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: