Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve tales header #335

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Feature/improve tales header #335

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b77947
Update [story].tsx
daria31v Jul 17, 2023
5da05b6
add property 'image' to - stories.ts and index.ts; change defult imag…
daria31v Jul 18, 2023
9a6013e
add changes - image current story
daria31v Jul 18, 2023
b05fd2e
Update [story].tsx
daria31v Jul 18, 2023
61c599f
fix
daria31v Jul 18, 2023
e349d75
Merge branch 'main' into feature/improve-tales-header
met Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/kids/stories/[story].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const StoriesContainer = ({ story, phrases }: StoriesProps): ReactNode => {
<SEO
title={`${title_current + ' - '}` + t(`seo.kids_page_storiesTitle.${getCountryVariant()}`)}
description={t(`seo.kids_page_storiesDescription.${getCountryVariant()}`)}
image={`https://www.movapp.cz/kids/' + ${image_current_story} + '.jpg'`}
image={`'https://www.movapp.cz/kids/' + ${image_current_story} + '.jpg'`}
Copy link
Contributor

@jejdacz jejdacz Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need any ...
image={<backtick>https://www.movapp.cz/kids/${image_current_story}.jpg<backtick>}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a dynamic parameter ${}, we should use ``
or are you talking about a different way of specifying the link?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jejdacz Oh ,yes, you are right. My developing skills are old and obsolete ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marek is using `` but github makes a mess with comments formating.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Go it. I will change it tomorrow)

/>
{['cs', 'sk'].includes(getCountryVariant()) ? (
<>
Expand Down
Loading