Feature/improve tales header #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the title of the current story
…e to the current image of the story - [story].tsx
jejdacz
reviewed
Jul 18, 2023
| @@ -43,7 +43,7 @@ const StoriesContainer = ({ story, phrases }: StoriesProps): ReactNode => { | |||
| <SEO | |||
| title={`${title_current + ' - '}` + t(`seo.kids_page_storiesTitle.${getCountryVariant()}`)} | |||
| description={t(`seo.kids_page_storiesDescription.${getCountryVariant()}`)} | |||
| image={`https://www.movapp.cz/kids/' + ${image_current_story} + '.jpg'`} | |||
| image={`'https://www.movapp.cz/kids/' + ${image_current_story} + '.jpg'`} | |||
There was a problem hiding this comment.
I think you don't need any ...
image={<backtick>https://www.movapp.cz/kids/${image_current_story}.jpg<backtick>}
There was a problem hiding this comment.
we have a dynamic parameter ${}, we should use ``
or are you talking about a different way of specifying the link?
There was a problem hiding this comment.
@jejdacz Oh ,yes, you are right. My developing skills are old and obsolete ;)
There was a problem hiding this comment.
Marek is using `` but github makes a mess with comments formating.
There was a problem hiding this comment.
Okay. Go it. I will change it tomorrow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image link fixes