Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: providing a minimal launcher written in flutter for ubuntu frame #191

Merged
merged 20 commits into from
Jul 26, 2024
Merged

feature: providing a minimal launcher written in flutter for ubuntu frame #191

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9417e15
feature: providing a minimal launcher written in flutter for ubuntu f…
mattkae Jun 24, 2024
1b431ec
feedback: run-client-wait when running the launcher so that we have a…
mattkae Jun 24, 2024
4429074
feedback: plugs.json + remove config_changes check in configure + README
mattkae Jun 24, 2024
0337ef1
rename run-client-wait to wayland-launch + license
mattkae Jun 24, 2024
df4e362
Revert accidental change
mattkae Jun 24, 2024
16dcc95
Checking if interfaces are connected
mattkae Jun 25, 2024
0b4ed7d
update: less verbose is-connected checks
mattkae Jun 25, 2024
fdaf845
disable snap build for flutter launcher on armhf since it does not su…
mattkae Jul 16, 2024
e4cc052
if trying to enable the launcher on an armhf system. ten we throw an …
mattkae Jul 16, 2024
5595548
Enabling launcher only on x86, i32, and amd64 systems
mattkae Jul 16, 2024
ebdb4b1
Cuter check on the architecture conditional for launcher
mattkae Jul 16, 2024
e9069fb
daemon connects to desktop-launch and increased logging
mattkae Jul 17, 2024
7d758df
Merge branch 'feature/multi-app' of github.com:canonical/ubuntu-frame…
mattkae Jul 17, 2024
37a7375
Set XDG_DATA_DIRS for the daemon
mattkae Jul 17, 2024
9dea9dc
Update scripts/bin/wayland-launch
mattkae Jul 18, 2024
b157596
snap: using wayplug instead of wayslot
mattkae Jul 18, 2024
17bd048
configure: fix arm64 -> aarch64
Saviq Jul 25, 2024
e149fa7
launcher: pin to Flutter 3.19.6
Saviq Jul 25, 2024
f29e1a4
configure: require desktop-launch to enable the launcher
Saviq Jul 25, 2024
bc5d16f
snap: add disconnect plug on desktop-launch
Saviq Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions snap/hooks/configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ fi

# Start or stop the launcher
if [ "$(snapctl get launcher)" = "true" ]; then
Saviq marked this conversation as resolved.
Show resolved Hide resolved
if [ $(uname -m) = "arm" ]; then
echo "Cannot enable the launcher on an armhf system"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also build for risc, so best reverse that. Maybe there's something in the environment we can use?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse as in have an allow-list, not a deny-list

exit 1
fi

if snapctl services "$SNAP_INSTANCE_NAME.launcher" | grep -q inactive; then
snapctl start --enable "$SNAP_INSTANCE_NAME.launcher" 2>&1 || true
fi
Expand Down
Loading