-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: providing a minimal launcher written in flutter for ubuntu frame #191
Conversation
@mattkae can you please draft a documentation page for this? Particularly on what are the requirements for an icon to show up. Just pop it in here and we'll copy to Discourse Docs when ready (or just publish on DD already with a "Work in progress" note). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handful of small tweaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and you'll need this to please the review tools:
diff --git a/snap/local/plugs.json b/snap/local/plugs.json
new file mode 100644
index 0000000..426efa7
--- /dev/null
+++ b/snap/local/plugs.json
@@ -0,0 +1,5 @@
+{
+ "desktop-launch":{
+ "allow-installation": "true"
+ }
+}
https://github.com/canonical/ubuntu-frame/actions/runs/9646782833/job/26604055393?pr=191 I am still seeing an error. Did I do it right? Just populated {
"desktop-launch": {
"allow-installation": "true"
}
} |
Please add copyright headers to the new files, too |
@Saviq: I just have the remaining question here about CI being broken. Documentation is in the description. |
Hmm Send button failed. We need the store ACK for this to pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tweaks, otherwise good!
(but we need to wait for the store ACK before landing)
Co-authored-by: Michał Sawicz <[email protected]>
@mattkae we'll need to disable this for See https://github.com/canonical/mir-test-tools/blob/7e593d47308ed20608d634b8b2525bb1df12bc2a/snap/snapcraft.yaml#L211-L229 for reference |
snap/hooks/configure
Outdated
if [ $(uname -m) = "arm" ]; then | ||
echo "Cannot enable the launcher on an armhf system" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also build for risc, so best reverse that. Maybe there's something in the environment we can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverse as in have an allow-list, not a deny-list
Co-authored-by: Michał Sawicz <[email protected]>
@Saviq Do you know what CI is angry about?
|
It just timed out, looks like LP went on hiatus. The "merge proposal" message is always there, just INFO when pushing to Launchpad git. |
snap/snapcraft.yaml
Outdated
slots: | ||
# Should be a plug but one snap can't have both the wayland slot and plug. This works. | ||
- wayland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we should actually reverse this and have a wayplug
instead. Some of our scripting relies on the :wayland
slot being there - and it's the more important side anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattkae so this is the last bit here, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Michał Sawicz <[email protected]>
Working around shader issue on Pi: flutter/flutter#152297
@AlanGriffiths since I was all over this, would you please have a look here, disregarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, just tweaked some of the snap details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible. Just one nit about disconnecting desktop-launch
without disabling the "launcher"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do
What's new?
launcher
, which is a minimal dock allowing the user to switch between fullscreen applicationDocumentation
Ubuntu Frame's
launcher
daemon provides users with a way to navigate between multiple applications running on a single frame instance.Enablement
To enable the launcher, run:
snap set ubuntu-frame launcher=true
Behavior
The following specifies the behavior that you can of the launcher daemon:
/var/lib/snapd/desktop
directory.application-x-executable
icon. If that fails, then the icon will be missing entirely.