Remove info files from github request app

README.md

@@ -5,8 +5,6 @@
 
 The GitHub request application is a tool designed to streamline and automate the process of managing and tracking request for GitHub. This includes the  adding, removal or editing of members.
 
-Each page or user interface, defined by an endpoint, is devided into three components (MVC) and as a best practice the names for the model, view and controller have, when possible, the same start name of the endpoints (e.g. for the `/info` page we have the: `info.controller.ts` and `info.html` files if models are present we would have `info.model.ts`)
-
 ### The View
 
 We use `Nunjucks` and `GDS` style/components.

src/config/index.ts

@@ -9,16 +9,13 @@ export const PATH_SSL_CERTIFICATE = process.env['PATH_SSL_CERTIFICATE'] || '';
 export const SERVICE_NAME = 'Node Prototype';
 
 // Template
-export const LANDING_PAGE = 'info';
 export const NOT_FOUND = 'page-not-found';
 export const ERROR_PAGE = 'error';
 export const CONFIRMATION = 'confirmation';
 
 // Routing paths
-export const LANDING_URL = '/info';
 
-export const INFO_URL = '/info';
 export const HEALTHCHECK_URL = '/healthcheck';
 export const CONFIRMATION_URL = '/confirmation';
-export const SERVICE_URL = `${BASE_URL}${LANDING_URL}`;
+export const SERVICE_URL = `${BASE_URL}${CONFIRMATION_URL}`;
 

src/routes/index.ts

@@ -2,14 +2,12 @@ import { Router } from 'express';
 
 import { logger } from '../middleware/logger.middleware';
 import healthcheckRouter from './healthcheck';
-import infoRouter from './info';
 import confirmationRouter from './confirmation';
 
 const router = Router();
 
 router.use(logger);
 router.use(healthcheckRouter);
-router.use(infoRouter);
 router.use(confirmationRouter);
 
 export default router;

test/integration/controller/error.spec.ts

@@ -1,20 +1,20 @@
-jest.mock('../../../src/controller/info.controller');
+jest.mock('../../../src/controller/confirmation.controller');
 jest.mock('../../../src/utils/logger');
 
 import { jest, beforeEach, describe, expect, test } from '@jest/globals';
 import request from 'supertest';
 
 import app from '../../../src/app';
 import * as config from '../../../src/config';
-import * as infoController from '../../../src/controller/info.controller';
+import * as confirmationController from '../../../src/controller/confirmation.controller';
 import {
     MOCK_NOT_FOUND_RESPONSE,
     MOCK_ERROR_MESSAGE,
     MOCK_SERVICE_UNAVAILABLE,
     MOCK_WRONG_URL
 } from '../../mock/text.mock';
 
-const mockGet = infoController.get as jest.Mock;
+const mockGet = confirmationController.get as jest.Mock;
 
 describe('Error integration tests', () => {
     beforeEach(() => {
@@ -32,7 +32,7 @@ describe('Error integration tests', () => {
         mockGet.mockImplementationOnce(() => {
             throw new Error(MOCK_ERROR_MESSAGE);
         });
-        const res = await request(app).get(config.LANDING_URL);
+        const res = await request(app).get(config.CONFIRMATION_URL);
 
         expect(res.status).toEqual(500);
         expect(res.text).toContain(MOCK_SERVICE_UNAVAILABLE);

test/mock/text.mock.ts

@@ -1,5 +1,3 @@
-export const MOCK_GET_INFO_RESPONSE = 'Placeholder - Info Page';
-export const MOCK_POST_INFO_RESPONSE = 'post request test';
 export const MOCK_OK_RESPONSE = 'OK';
 export const MOCK_GET_CONFIRMATION_RESPONSE = 'GitHub request complete';
 export const MOCK_NOT_FOUND_RESPONSE = 'Page not found';