Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove info files from github request app #7

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

mel-am
Copy link
Contributor

@mel-am mel-am commented Jan 18, 2024

JIRA link

NTRNL-306

Description

Removes info

Work checklist

  • Tests added where applicable
  • No vulnerability added

@mel-am mel-am requested a review from a team January 18, 2024 13:07
@mel-am mel-am self-assigned this Jan 18, 2024
Copy link

github-actions bot commented Jan 18, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 141/141
🟢 Branches 95.24% 20/21
🟢 Functions 100% 13/13
🟢 Lines 100% 128/128

Test suite run success

20 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 2e38c1f

Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mel-am, could you please update test.mock.ts and Readme files, furthermore the info.html template file should be removed.

Note: always add the story id to your branch name, thanks

src/config/index.ts Outdated Show resolved Hide resolved
@mel-am mel-am changed the title removes info Remove info files from github request app Jan 18, 2024
README.md Show resolved Hide resolved
@mel-am mel-am merged commit bd36488 into main Jan 19, 2024
3 checks passed
@mel-am mel-am deleted the remove-info-references branch January 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants