Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change add-team page based on UX redesign #58

Merged
merged 1 commit into from
Mar 27, 2024
Merged

change add-team page based on UX redesign #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/views/add-team.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
{% endblock %}

{% block pageContent %}
<h1 class="govuk-heading-l">Add a GitHub Team</h1>
<h1 class="govuk-heading-l">Add a new team</h1>

<p class="govuk-body">
GitHub Teams can be used to manage repository permissions and mentions for groups of members.
Teams are groups of organisation members that reflect your company or group's structure with cascading access permissions and mentions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but the commit message duplicates the branch name. I would rename the commit to make it more semantic Update Add Team description to be consistent with the style from teams documentation on GitHub or equivalent

</p>

{% include "include/error-list.html" %}
Expand Down
2 changes: 1 addition & 1 deletion test/mock/text.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const MOCK_BY_ID_ADD_MEMBER_RESPONSE = 'GitHub handle: example, Member ID

// add-team reponse mocks

export const MOCK_GET_ADD_TEAM_RESPONSE = 'Add a GitHub Team';
export const MOCK_GET_ADD_TEAM_RESPONSE = 'Add a new team';
export const MOCK_POST_ADD_TEAM_RESPONSE = 'Team Name: team1, Team Maintainer GitHub Handle: bob, Team ID: ';
export const MOCK_BY_ID_TEAM_RESPONSE = 'Team Name: team1, Team ID: ';

Expand Down
Loading