change add-team page based on UX redesign #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success151 tests passing in 39 suites. Report generated by 🧪jest coverage report action from aedfa0c |
| @@ -8,7 +8,7 @@ | |||
| <h1 class="govuk-heading-l">Add a GitHub Team</h1> | |||
|
|
|||
| <p class="govuk-body"> | |||
| GitHub Teams can be used to manage repository permissions and mentions for groups of members. | |||
| Teams are groups of organisation members that reflect your company or group's structure with cascading access permissions and mentions. | |||
There was a problem hiding this comment.
Very minor, but the commit message duplicates the branch name. I would rename the commit to make it more semantic Update Add Team description to be consistent with the style from teams documentation on GitHub or equivalent
|
Page heading should be the same text as on |
…s documentation on GitHub
DanielMurray97
force-pushed
the
NTRNL-401-update-add-team-page-based-on-ui-ux-review
branch
from
7628578
to
aedfa0c
Compare
harley-harris
approved these changes
Mar 27, 2024
DanielMurray97
deleted the
NTRNL-401-update-add-team-page-based-on-ui-ux-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
Resolves NTRNL-401
Description
Work checklist