Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially confusing mistake in comment at 3d/generate_custom_mesh example #15261

Closed
Oskuz opened this issue Sep 17, 2024 · 0 comments · Fixed by #15266
Closed

Potentially confusing mistake in comment at 3d/generate_custom_mesh example #15261

Oskuz opened this issue Sep 17, 2024 · 0 comments · Fixed by #15266
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples

Comments

@Oskuz
Copy link

Oskuz commented Sep 17, 2024

In comment about indices in example (examples/3d/generate_custom_mesh.rs) comments tell that indices should be listed in counter-clockwise order when in code under comment they are listed in clockwise order.

Maybe add some basic ascii art to demonstrate triangles in comments?
@Oskuz Oskuz added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Sep 17, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Sep 17, 2024
Wcubed added a commit to Wcubed/bevy that referenced this issue Sep 17, 2024
@Wcubed
Add ASCII art to custom mesh example (bevyengine#15261)
bcb1988
@Wcubed Wcubed mentioned this issue Sep 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
@Wcubed
Add ASCII art to custom mesh example (#15261) (#15266)
13ca08f 
Added ASCII art to the custom mesh example, to clarify the ordering of
the triangle indices.
Fixes #15261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ASCII art to custom mesh example (#15261) Wcubed/bevy
2 participants
@alice-i-cecile @Oskuz