Skip to content

fix member variable type and error logs

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 2, 2024 in 40s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.04 (7.49 -> 7.46)

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 1 findings(s) βœ…

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method tensorrt_yolox_node.cpp: TrtYoloXNode::TrtYoloXNode
  • Complex Method tensorrt_yolox_node.cpp: TrtYoloXNode::onImage

βœ… Improving Code Health:

  • Overall Code Complexity tensorrt_yolox_node.cpp

Annotations

Check warning on line 141 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrtYoloXNode::onImage increases in cyclomatic complexity from 10 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 97 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

TrtYoloXNode::TrtYoloXNode increases from 73 to 77 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.43 to 5.25, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.