Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): set RTC enable #9040

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Oct 7, 2024

Description

In the intersection module, member variable rtc_enabled_ was not set appropriately.
This functions sets the rtc_enabled_ according to the RTC interface.

Related links

#5697

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori marked this pull request as ready for review October 7, 2024 02:41
@go-sakayori go-sakayori added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.54%. Comparing base (1e26395) to head (7552407).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...avior_velocity_intersection_module/src/manager.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9040      +/-   ##
==========================================
- Coverage   26.55%   26.54%   -0.02%     
==========================================
  Files        1296     1301       +5     
  Lines       95711    95763      +52     
  Branches    38983    38986       +3     
==========================================
+ Hits        25419    25420       +1     
- Misses      67725    67775      +50     
- Partials     2567     2568       +1     
Flag Coverage Δ *Carryforward flag
differential 17.48% <0.00%> (?)
total 26.55% <ø> (ø) Carriedforward from 1e26395

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 4f97001 into autowarefoundation:main Oct 7, 2024
45 of 46 checks passed
@soblin soblin deleted the fix/intersection branch October 7, 2024 03:03
go-sakayori added a commit to tier4/autoware.universe that referenced this pull request Oct 7, 2024
rej55 added a commit to tier4/autoware.universe that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants