Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mission_planner): add unit tests of utility functions #9011

Merged

test(mission_planner): add unit tests of utility functions

bee6701
Select commit
Loading
Failed to load commit list.
Merged

test(mission_planner): add unit tests of utility functions #9011

test(mission_planner): add unit tests of utility functions
bee6701
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Oct 3, 2024 in 36s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 8.99

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication test_utility_functions.cpp
  • Large Method test_utility_functions.cpp: TEST:TestUtilityFunctions:TestUtilityFunctions

Annotations

Check warning on line 268 in planning/autoware_mission_planner/test/test_utility_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: TEST:TestUtilityFunctions:is_in_parking_lot,TEST:TestUtilityFunctions:is_in_parking_space. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 423 in planning/autoware_mission_planner/test/test_utility_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:TestUtilityFunctions:TestUtilityFunctions has 76 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.