refactor(lane_change): replace any code that can use transient data #8999
+74
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
zulfaqar-azmi-t4
force-pushed
the
RT1-8004-replace-any-code-that-can-use-transient-data
branch
from
6babfcf
to
eef3cc4
Compare
zulfaqar-azmi-t4
requested review from
mkquda,
rej55,
kosuke55,
maxime-clem,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
mkquda
reviewed
Oct 3, 2024
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
zulfaqar-azmi-t4
force-pushed
the
RT1-8004-replace-any-code-that-can-use-transient-data
branch
from
eef3cc4
to
91b60e9
Compare
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
This reverts commit e9cc386.
This reverts commit 775bcdb.
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
RT1-8004-replace-any-code-that-can-use-transient-data
branch
from
91b60e9
to
67114cc
Compare
Signed-off-by: Zulfaqar Azmi <[email protected]>
github-actions
bot
added
the
type:documentation
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
zulfaqar-azmi-t4
merged commit 85f578c
into
autowarefoundation:main
35 of 36 checks passed
zulfaqar-azmi-t4
deleted the
RT1-8004-replace-any-code-that-can-use-transient-data
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8999 +/- ##
=======================================
Coverage 26.21% 26.22%
=======================================
Files 1302 1303 +1
Lines 96925 96913 -12
Branches 39159 39132 -27
=======================================
+ Hits 25409 25411 +2
+ Misses 68928 68911 -17
- Partials 2588 2591 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors lane change code using TransientData to improve code quality and readability, and reduce complexity.
The function that is no longer used is removed.
Also is_ego stuck is added to transient data.
Related links
Parent Issue:
How was this PR tested?
TIER IV internal evaluator
TIER IV internal evaluator - after swapping filterObjects
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.