Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ground_segmentation): rework parameter #8988

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

prakash-kannaiah
Copy link
Contributor

Description


Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the ground_segmentation package.

  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.

Tests performed


No.

Pre-review checklist for the PR author


The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers


The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author


The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone with write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YoshiRi YoshiRi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 30, 2024
@YoshiRi
Copy link
Contributor

YoshiRi commented Sep 30, 2024

@prakash-kannaiah
Thanks for your work! but could you solve DCO error with sign-off missing?

Commit sha: 7edd0c9, Author: Prakash Kannaiah, Committer: GitHub; The sign-off is missing.
Commit sha: 59edf47, Author: prakash-kannaiah, Committer: prakash-kannaiah; The sign-off is missing.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.04%. Comparing base (5a0e100) to head (efc3501).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8988      +/-   ##
==========================================
- Coverage   26.16%   26.04%   -0.12%     
==========================================
  Files        1295     1317      +22     
  Lines       96950    98440    +1490     
  Branches    39159    39989     +830     
==========================================
+ Hits        25364    25636     +272     
- Misses      68992    70098    +1106     
- Partials     2594     2706     +112     
Flag Coverage Δ *Carryforward flag
differential 10.98% <ø> (?)
total 26.09% <ø> (-0.07%) ⬇️ Carriedforward from c47b33b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Oct 1, 2024
@badai-nguyen
Copy link
Contributor

@prakash-kannaiah Thanks for your PR, could you also fix for json-schema-check / json-schema-check (pull_request)

perception/autoware_ground_segmentation/schema/ground_segmentation.schema.json ❌ Failed

Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants