-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ground_segmentation): rework parameter #8988
base: main
Are you sure you want to change the base?
refactor(ground_segmentation): rework parameter #8988
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@prakash-kannaiah
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8988 +/- ##
==========================================
- Coverage 26.16% 26.04% -0.12%
==========================================
Files 1295 1317 +22
Lines 96950 98440 +1490
Branches 39159 39989 +830
==========================================
+ Hits 25364 25636 +272
- Misses 68992 70098 +1106
- Partials 2594 2706 +112
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@prakash-kannaiah Thanks for your PR, could you also fix for
|
Signed-off-by: prakash-kannaiah <[email protected]>
efc3501
to
23af119
Compare
Description
Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the
ground_segmentation
package.Tests performed
No.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone with write access can merge the PR.