fix(lidar_apollo_instance_segmentation): fix critical bug #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kminoda
added
the
tag:run-build-and-test-differential
|
🙇 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8444 +/- ##
==========================================
- Coverage 23.89% 23.83% -0.07%
==========================================
Files 1380 1379 -1
Lines 101864 101423 -441
Branches 38783 38532 -251
==========================================
- Hits 24343 24174 -169
+ Misses 75075 74789 -286
- Partials 2446 2460 +14
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
component:launch
kminoda
requested review from
YoshiRi,
yukkysaito,
miursh and
technolojin
as code owners
technolojin
reviewed
Aug 14, 2024
| @@ -47,7 +47,7 @@ | |||
| <arg name="input/pointcloud" default="/sensing/lidar/concatenated/pointcloud" description="The topic will be used in the detection module"/> | |||
| <arg name="mode" default="camera_lidar_fusion" description="options: `camera_lidar_radar_fusion`, `camera_lidar_fusion`, `lidar_radar_fusion`, `lidar` or `radar`"/> | |||
| <arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/> | |||
| <arg name="lidar_detection_model" default="centerpoint" description="options: `transfusion`, `centerpoint`, `apollo`, `pointpainting`, `clustering`"/> | |||
| <arg name="lidar_detection_model" default="apollo" description="options: `transfusion`, `centerpoint`, `apollo`, `pointpainting`, `clustering`"/> | |||
There was a problem hiding this comment.
Is it for debug or want to change default to apollo?
There was a problem hiding this comment.
Thanks, that's a mistake. Fixed with the latest version.
kminoda
force-pushed
the
fix/apollo/add_appropriate_reference
branch
from
87377f2
to
aba7e3c
Compare
github-actions
bot
removed
the
component:launch
kminoda
added
the
tag:pr-agent
|
CI keeps failing 😢 |
Shin-kyoto
approved these changes
Aug 15, 2024
yukkysaito
approved these changes
Aug 19, 2024
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…undation#8444) Signed-off-by: kminoda <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original code included a critical bug which caused an empty output from apollo node.
Related links
Parent Issue:
How was this PR tested?
We've tested with
Note that this doesn't fix the issues we had internally: https://evaluation.tier4.jp/evaluation/reports/2921e69d-65b2-5067-af4b-8fffa4166d74?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.