Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tensorrt_yolox): add GPU - CUDA device option #8245

Merged

Merge branch 'main' into feat/yolox-add-device-option

d3889b5
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_tensorrt_yolox): add GPU - CUDA device option #8245

Merge branch 'main' into feat/yolox-add-device-option
d3889b5
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 27, 2024 in 47s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (5.61 -> 5.61)

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method tensorrt_yolox.cpp: TrtYoloX::TrtYoloX
  • Large Method tensorrt_yolox_node.cpp: TrtYoloXNode::TrtYoloXNode

✅ Improving Code Health:

  • Overall Code Complexity tensorrt_yolox.cpp
  • Primitive Obsession tensorrt_yolox.cpp

Annotations

Check warning on line 106 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

TrtYoloXNode::TrtYoloXNode increases from 73 to 80 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.57 to 5.71, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1054 to 1073, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 272 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrtYoloX::TrtYoloX increases in cyclomatic complexity from 22 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.48 to 5.44, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Primitive Obsession

The ratio of primitive types in function arguments decreases from 40.82% to 39.22%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check notice on line 1 in perception/autoware_traffic_light_fine_detector/src/traffic_light_fine_detector_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.67 to 4.78, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.