feat(autoware_test_utils): add qos handler in pub/sub #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <[email protected]>
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
YoshiRi
requested review from
kyoichi-sugahara,
soblin,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
YoshiRi
added
the
tag:run-build-and-test-differential
Signed-off-by: yoshiri <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7856 +/- ##
==========================================
- Coverage 23.89% 23.86% -0.03%
==========================================
Files 1381 1384 +3
Lines 101831 101865 +34
Branches 38780 38782 +2
==========================================
- Hits 24333 24314 -19
- Misses 75035 75086 +51
- Partials 2463 2465 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
approved these changes
Jul 30, 2024
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…tion#7856) * feat: add qos handler in pub/sub Signed-off-by: yoshiri <[email protected]> * style(pre-commit): autofix * feat: update test_pub_msg function to not use setpublisher function Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: xtk8532704 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable to give pub/sub qos settings by external argument.
Disable automatic qos overwrite in
setPublisherfunction.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.