Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_stop_line_module): prefix package and namespace with autoware_ #7285

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 5, 2024

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

autowarefoundation/autoware#4569

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 5, 2024
@esteve esteve force-pushed the prefix-behavior_velocity_stop_line_module branch from 32ca413 to 2c6941c Compare June 5, 2024 13:52
@esteve esteve self-assigned this Jun 5, 2024
@esteve esteve marked this pull request as ready for review June 5, 2024 13:54
@esteve esteve enabled auto-merge (squash) June 5, 2024 13:55
@esteve esteve force-pushed the prefix-behavior_velocity_stop_line_module branch from 927a2e9 to ec12080 Compare June 5, 2024 13:56
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 5, 2024
@esteve esteve force-pushed the prefix-behavior_velocity_stop_line_module branch from ec12080 to ea91ec1 Compare June 6, 2024 10:40
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esteve
Thank you for your work!
Regarding to this PR, it is necessary to handle the conflicts.
Could you resolve the conflicts, please?
#7314

@esteve esteve force-pushed the prefix-behavior_velocity_stop_line_module branch 2 times, most recently from a9107be to 64c8c9a Compare June 7, 2024 11:06
@esteve esteve force-pushed the prefix-behavior_velocity_stop_line_module branch from 64c8c9a to b4f2efb Compare June 7, 2024 11:20
@esteve
Copy link
Contributor Author

esteve commented Jun 7, 2024

@rej55 I've fixed the conflicts. Could you have a look at the changes when you have a moment? Thanks.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! and sorry for late approve 🙇
Please feel to ping me 🙏 Late approvall is all my fault though...

@esteve esteve merged commit ddce1de into main Jun 10, 2024
23 of 25 checks passed
@esteve esteve deleted the prefix-behavior_velocity_stop_line_module branch June 10, 2024 01:51
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…space with autoware_ (#7285)

* refactor(behavior_velocity_stop_line_module): prefix package and namespace with autoware_

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants