Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geography_utils): add projection in geography_utils #4833

Merged
merged 52 commits into from
Sep 4, 2023

Merge branch 'main' into feat/gnss_poser/use_lanelet2_projector

a952c87
Select commit
Loading
Failed to load commit list.
Merged

feat(geography_utils): add projection in geography_utils #4833

Merge branch 'main' into feat/gnss_poser/use_lanelet2_projector
a952c87
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 4, 2023 in 1m 7s

CodeScene PR Check

❌ Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Complex Method gnss_poser_core.cpp: GNSSPoser::callbackNavSatFix

Annotations

Check warning on line 106 in sensing/gnss_poser/src/gnss_poser_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

GNSSPoser::callbackNavSatFix already has high cyclomatic complexity, and now it increases in Lines of Code from 84 to 90. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis