chore(deps): Migrate to bzl mod dependencies #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
force-pushed
the
bzl_mod
branch
5 times, most recently
from
ccfd06b
to
9636f92
Compare
jbedard
reviewed
Apr 9, 2024
jbedard
reviewed
Apr 9, 2024
| # | ||
| # Note that you should also run integration_tests against other Bazel | ||
| # versions you support. | ||
| 7.1.0 |
There was a problem hiding this comment.
Did version 7 with --enable_bzlmod=false cause any issues that can be fixed+merged on their own before enabling bzlmod?
There was a problem hiding this comment.
I'd prefer not to. There are errors since I'm using rules that aren't bazel 7 compatible (the version of rules_js is quite old). I'd prefer to update the deps once rather than twice if that's okay
jbedard
reviewed
Apr 9, 2024
jbedard
reviewed
Apr 9, 2024
Move all tests to the e2e directory so that they properly test the bzl_mod setup.
jbedard
reviewed
Apr 10, 2024
| @@ -13,3 +13,15 @@ build --reuse_sandbox_directories | |||
| # Avoid this flag being enabled by remote_download_minimal or remote_download_toplevel | |||
| # See https://meroton.com/blog/bazel-6-errors-build-without-the-bytes/ | |||
| build --noexperimental_action_cache_store_output_metadata | |||
|
|
|||
There was a problem hiding this comment.
Were these caused by bzlmod using a newer version of aspect_bazel_lib then what we had declared in WORKSPACE? Now bzlmod takes the latest declared dep instead of the first declared...
jbedard
reviewed
Apr 10, 2024
jbedard
approved these changes
Apr 10, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
This reverts commit cf5ed54.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Augment the release note generation to reference the new bzlmod setup.
Type of change
For changes visible to end-users
Test plan