Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mrmeku committed Apr 9, 2024
1 parent 9636f92 commit 00fc774
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
3 changes: 0 additions & 3 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ register_toolchains("@cypress_toolchains//:all")
bazel_dep(name = "platforms", version = "0.0.5")
bazel_dep(name = "aspect_rules_js", version = "1.38.0")

####### Node.js version #########
# By default you get the node version from DEFAULT_NODE_VERSION in @rules_nodejs//nodejs:repositories.bzl
# Optionally you can pin a different node version:
bazel_dep(name = "rules_nodejs", version = "5.8.2")

node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
Expand Down
18 changes: 16 additions & 2 deletions e2e/workspace/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
load("@npm//:defs.bzl", "npm_link_all_packages")
"""Provides a simple way to test your rules as an external workspace.
Add a basic smoke-test target below.
"""

npm_link_all_packages(name = "node_modules")
load("@bazel_skylib//rules:build_test.bzl", "build_test")
# load("aspect_rules_cypress//cypress:defs.bzl", "...")

# Replace with a usage of your rule/macro
filegroup(name = "empty")

build_test(
name = "smoke_test",
targets = [
# targets you add above
":empty",
],
)

0 comments on commit 00fc774

Please sign in to comment.