Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Category getAllMembers to use queryGen #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brianckeegan
Copy link

No description provided.

@@ -1,4 +1,4 @@
# -*- coding: utf-8 -*-
# -*- coding: utf-8 -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently in December 2008, byte order marks (U+FEFF) were added to files for "utf-8": 8708055.

@mzmcbride
Copy link
Collaborator

@alexz-enwp: Any thoughts on this pull request?

Do we still need the byte order marks?

It'd be real nice to get rid of the bare except here (https://github.com/alexz-enwp/wikitools/pull/38/files#diff-330719e502db51fe8082141888459f62L114). I think wikitools is currently swallowing a legitimate error. :-/

Tangentially, I keep meaning to help out with this repo, but there are certain aspects I don't understand well enough that are tripping me up. I don't know when to increment the version number (I think we're currently at 1.3 or 1.4) or whether I should be touching the version number at all. I also don't know how to get https://pypi.python.org/pypi/wikitools updated.

@alexz-enwp
Copy link
Owner

I don't know what the purpose of the byte order marks is...

For this pull request, it would be nice to clean up this code (and I've done that in the major overhaul branch I'm working on 151ba06). But this change looks like it inadvertently drops the ability to get the results as page objects vs titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants