Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Cleanups suggested by ruff #18

Merged
merged 8 commits into from
May 17, 2024
Merged

FIX: Cleanups suggested by ruff #18

merged 8 commits into from
May 17, 2024

Commits on Jan 19, 2024

  1. FIX: Undefined variable should be unused ge_cas

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2127037 View commit details
    Browse the repository at this point in the history

  2. STY: Remove unused imports

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    bd794a1 View commit details
    Browse the repository at this point in the history

  3. MNT: Configure ruff to ignore things that are okay

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ade8b71 View commit details
    Browse the repository at this point in the history

  4. RF: Clean up coef_file_parse() 

    * Use context manager to ensure file is closed promptly
* Skip unnecessary regex compilation
* Give line fields variable a meaningful name
    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d777671 View commit details
    Browse the repository at this point in the history

  5. FIX: Provide a more informative error for get_ge_coef

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    950537c View commit details
    Browse the repository at this point in the history

  6. STY: Keep imports at top of files

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3853fae View commit details
    Browse the repository at this point in the history

  7. RF: Remove indirect import of math.factorial

    @effigies
    effigies committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b6f57b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. FIX: Revert "valid line" condition, but keep the shorter name

    @effigies
    effigies committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    75de7dc View commit details
    Browse the repository at this point in the history