FIX: Cleanups suggested by ruff #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use context manager to ensure file is closed promptly * Skip unnecessary regex compilation * Give line fields variable a meaningful name
effigies
commented
Jan 19, 2024
effigies
commented
Jan 19, 2024
effigies
commented
Jan 19, 2024
|
Looks good to me, leaving it for a bit so others can look if they want. |
|
Is that good to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran ruff on gradunwarp after the latest merge. I found a number of cleanups, including some things that I think are bugs that need fixing. I tried to keep the individual commits clean, but I'll annotate with comments below.