Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[product-4] Implement Product API for front-end: Get the list of all products #58
[product-4] Implement Product API for front-end: Get the list of all products #58
Changes from 6 commits
aab5673
49a2915
d208e2d
a2b997a
83b9ebb
782a219
f6f2dc8
73f5bc3
142594f
c1a3f2b
a112531
7519bf3
207edc1
c20c908
c58382c
98bd7e2
668a8e0
cdbfe52
27c1ec2
2e93711
34a7368
c6cdf5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
productInfoRepository
andproductInfoDtoConverter
fromProductsEndpoint
class, repository and converter classes should be injected to service class likeProductInfoService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename id like
productId
pleaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename id like
productId
pleaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create
getProductById
method inProductInfoService
andProductInfoServiceImpl
and use this class here likeproductInfoService.getProductById(productId);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test this?
does it work?
Please test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method returns not all products, it returns some limited products
rename method name like
getProducts
please