[product-4] Implement Product API for front-end: Get the list of all products #58

UladzislauM · 2023-07-24T08:26:52Z

Implement Product API for front-end: Get the list of all products.

changed the controller according to business requirements;
added ProductInfoRequestResponseDto;
added Service;
corrected Repository.

src/main/java/com/zufar/onlinestore/product/converter/ProductInfoDtoConverter.java

Sunagatov · 2023-07-27T00:59:56Z

src/main/java/com/zufar/onlinestore/product/service/ProductInfoService.java

+
+public interface ProductInfoService {
+
+    Page<ProductInfoRequestResponseDto> getAllProducts(Pageable pageable);


did you test this?
does it work?

Please test

src/main/java/com/zufar/onlinestore/product/service/ProductInfoService.java

Sunagatov · 2023-07-27T01:05:26Z

src/main/java/com/zufar/onlinestore/product/endpoint/ProductsEndpoint.java

    private final ProductInfoRepository productInfoRepository;
    private final ProductInfoDtoConverter productInfoDtoConverter;
+    private final ProductInfoService productInfoService;

    @GetMapping("/{id}")
    public ResponseEntity<ProductInfoDto> getProductInfoById(@PathVariable("id") final String id) {


rename id like productId please

Sunagatov · 2023-07-27T01:05:30Z

src/main/java/com/zufar/onlinestore/product/endpoint/ProductsEndpoint.java

    private final ProductInfoRepository productInfoRepository;
    private final ProductInfoDtoConverter productInfoDtoConverter;
+    private final ProductInfoService productInfoService;

    @GetMapping("/{id}")


rename id like productId please

Sunagatov · 2023-07-27T01:08:43Z

src/main/java/com/zufar/onlinestore/product/endpoint/ProductsEndpoint.java


    @GetMapping("/{id}")
    public ResponseEntity<ProductInfoDto> getProductInfoById(@PathVariable("id") final String id) {
        log.info("Received request to get the ProductInfo with id - {}.", id);
-        Optional<ProductInfo> ProductInfo = productInfoRepository.findById(Integer.parseInt(id));
+        Optional<ProductInfo> ProductInfo = productInfoRepository.findById(UUID.fromString(id));


create getProductById method in ProductInfoService and ProductInfoServiceImpl and use this class here like productInfoService.getProductById(productId);

src/main/java/com/zufar/onlinestore/product/dto/ProductInfoRequestResponseDto.java

AiratGimaev · 2023-07-28T10:10:54Z

src/main/java/com/zufar/onlinestore/product/service/impl/ProductInfoServiceImpl.java

+@Slf4j
+@RequiredArgsConstructor
+@Service
+public class ProductInfoServiceImpl implements ProductApi {


-Impl is redundant

AiratGimaev · 2023-07-28T10:14:00Z

src/main/java/com/zufar/onlinestore/product/endpoint/ProductsEndpoint.java

-    public ResponseEntity<Collection<ProductInfoDto>> getAllProducts() {
-        log.info("Received request to get all ProductInfos");
-        Collection<ProductInfo> productInfoCollection = productInfoRepository.findAll();
+    public ResponseEntity<Page<ProductResponseDto>> getAllProducts(Pageable pageable) {


Pageable is an interface not class. How do you want map json to this interface ? Parameters for page should be passed through /products?page=X&pageSize=N

AiratGimaev · 2023-07-28T10:15:19Z

src/main/java/com/zufar/onlinestore/product/endpoint/ProductsEndpoint.java

-    public ResponseEntity<Collection<ProductInfoDto>> getAllProducts() {
-        log.info("Received request to get all ProductInfos");
-        Collection<ProductInfo> productInfoCollection = productInfoRepository.findAll();
+    public ResponseEntity<Page<ProductResponseDto>> getAllProducts(Pageable pageable) {


Why do you return Page<ProductResponseDto> instead of Collection<ProductResponseDto> ?

Pageable and Page is a data layer interfaces and should be used only in Service and Repository

AiratGimaev · 2023-07-28T10:21:20Z

src/main/java/com/zufar/onlinestore/product/service/ProductApi.java

+
+public interface ProductApi {
+
+    Page<ProductResponseDto> getProducts(Pageable pageable);


The same. Our API should be clear and not depend on org.springframework.data.domain.Page and org.springframework.data.domain.Pageable;

Sanya124

Reviewed

…mic API

AiratGimaev

Approved

UladzislauM added 6 commits July 24, 2023 11:20

product-1: added a mapper for ProductInfoRequestResponseDto

aab5673

product-1: changed the type of id to UUID

49a2915

product-1: added ProductInfoRequestResponseDto

d208e2d

product-1: added ProductInfoService

a2b997a

product-1: changed the controller according to business requirements

83b9ebb

product-1: corrected for correct paginated display of the display

782a219

Sunagatov reviewed Jul 27, 2023

View reviewed changes

UladzislauM added 3 commits July 27, 2023 06:57

product-4: renamed the DTO for the response

f6f2dc8

product-4: renamed the mapper DTO for the response

73f5bc3

product-4: renamed getAllProducts to getProducts

142594f

AiratGimaev reviewed Jul 28, 2023

View reviewed changes

UladzislauM and others added 9 commits July 28, 2023 13:38

product-4: renamed ProductInfoServiceImpl to ProductService

c1a3f2b

product-4: removed the extra imports

a112531

Merge branch 'Sunagatov:development' into feature/product-4

7519bf3

product-4: deleted pageable and add several parameters

207edc1

product-4: deleted pageable and add several parameters

c20c908

product-4: add dto for correct response

c58382c

product-4: changed endpoint for new request pattern

98bd7e2

product-4: changed service for new request pattern

668a8e0

product-4: corrected in compliance with the documentation

cdbfe52

UladzislauM changed the title ~~Feature/product 4~~ [product-4] Implement Product API for front-end: Get the list of all products Jul 31, 2023

product-4: fixed the design

27c1ec2

Sanya124 reviewed Jul 31, 2023

View reviewed changes

UladzislauM and others added 3 commits August 1, 2023 06:33

product-4: changed the service layer following the example of the ato…

2e93711

…mic API

Merge branch 'Sunagatov:development' into feature/product-4

34a7368

product-4: renamed the method for issuing all products

c6cdf5d

AiratGimaev approved these changes Aug 1, 2023

View reviewed changes

Sunagatov closed this Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[product-4] Implement Product API for front-end: Get the list of all products #58

[product-4] Implement Product API for front-end: Get the list of all products #58

UladzislauM commented Jul 24, 2023

Sunagatov Jul 27, 2023

Sunagatov Jul 27, 2023

Sunagatov Jul 27, 2023

Sunagatov Jul 27, 2023

AiratGimaev Jul 28, 2023

AiratGimaev Jul 28, 2023 •

edited

Loading

AiratGimaev Jul 28, 2023 •

edited

Loading

AiratGimaev Jul 28, 2023

AiratGimaev Jul 28, 2023 •

edited

Loading

Sanya124 left a comment

AiratGimaev left a comment


		public interface ProductInfoService {

		Page<ProductInfoRequestResponseDto> getAllProducts(Pageable pageable);


		public interface ProductApi {

		Page<ProductResponseDto> getProducts(Pageable pageable);

[product-4] Implement Product API for front-end: Get the list of all products #58

[product-4] Implement Product API for front-end: Get the list of all products #58

Conversation

UladzislauM commented Jul 24, 2023

Sunagatov Jul 27, 2023

Choose a reason for hiding this comment

Sunagatov Jul 27, 2023

Choose a reason for hiding this comment

Sunagatov Jul 27, 2023

Choose a reason for hiding this comment

Sunagatov Jul 27, 2023

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

Sanya124 left a comment

Choose a reason for hiding this comment

AiratGimaev left a comment

Choose a reason for hiding this comment

AiratGimaev Jul 28, 2023 •

edited

Loading

AiratGimaev Jul 28, 2023 •

edited

Loading

AiratGimaev Jul 28, 2023 •

edited

Loading