Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glob for issue #26 #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add glob for issue #26 #32

wants to merge 1 commit into from

Conversation

cybrown
Copy link

@cybrown cybrown commented Aug 11, 2015

Add glob for files option, issue #26

@kitsonk
Copy link
Contributor

kitsonk commented Sep 3, 2015

@cybrown we require CLAs for any contributions as part of the Dojo Foundation. I was unable to find a CLA based on your GitHub username. Could you please take a moment to file a CLA or let me know what username or e-mail address you used?

@cybrown
Copy link
Author

cybrown commented Sep 3, 2015

This PR will be merged if I accept the CLA ?

@kitsonk kitsonk self-assigned this Sep 3, 2015
@kitsonk
Copy link
Contributor

kitsonk commented Sep 3, 2015

I haven't looked at it in detail, but it seems logical to me, so I will try to land it.

@cybrown
Copy link
Author

cybrown commented Sep 3, 2015

I've signed the CLA, with my gmail: cy.brown59

@kitsonk
Copy link
Contributor

kitsonk commented Sep 4, 2015

Cy Brown submitted a CLA on 2015-09-03 13:44:25.

@kitsonk
Copy link
Contributor

kitsonk commented Sep 18, 2015

@cybrown sorry for taking so long to have a look at this... Would ultimately reading the tsconfig.json work for solving this (assuming it supports properly the globs property available in tsconfig.json)?

@cybrown
Copy link
Author

cybrown commented Sep 29, 2015

I don't think that reading the tsconfig.json would be a good idea because I think that in most workflows, the generated .d.ts files are outputed in another directory, leaving the source directory clean.

@dylanowen dylanowen mentioned this pull request Jul 16, 2016
Closed
dylans
dylans suggested changes Jan 12, 2017
View reviewed changes
Copy link
Contributor

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll go ahead and land this. It looks like there needs to be an adjustment to use tabs instead of spaces in a few lines of this PR.

@dylans dylans added this to the 2.1.0 milestone Jan 12, 2017
@dylans dylans modified the milestones: 2.2.0, 2.1.0 Jan 30, 2017
@dylans
Copy link
Contributor

dylans commented Jan 30, 2017

Pushing out to 2.2.0 as there are still changes to review.

@dylans dylans modified the milestones: 2.2.0, 3.0 Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans requested changes

Assignees
No one assigned
Labels
cla-checked
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cybrown @kitsonk @dylans