Fixed some bugs around excludes not resolving #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylans
suggested changes
Jan 12, 2017
| glob.sync(filename).forEach(function(globFileName) { | ||
| excludesMap[filenameToMid(pathUtil.resolve(baseDir, globFileName))] = true; | ||
| }); | ||
| options.exclude.forEach(function (filename) { |
There was a problem hiding this comment.
I believe the original options.exclude && was in case node_modules contained no *.d.ts files? Seems unlikely to have that issue though?
| return pathUtil.resolve(baseDir, filename); | ||
| }); | ||
| return glob.sync(pathUtil.resolve(baseDir, filename)); | ||
| }).reduce((result, pathArray) => { |
There was a problem hiding this comment.
Let's plan to rebase this after #32 lands.
|
Pushing out to 2.2.0 as there are still changes to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #32
I cleaned up exclude options to use the same file resolution as 'files' for consistency.
I signed with the CLA under my gmail: dyltotheo