Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing logic #120

Merged
merged 23 commits into from
Aug 16, 2024
Merged

Testing logic #120

merged 23 commits into from
Aug 16, 2024

Conversation

KaraMelih
Copy link
Collaborator

Once the snews_cs branch; https://github.com/SNEWS2/SNEWS_Coincidence_System/tree/internal_testing_logic

is merged, there will be 2 caches running in parallel and no need to change topics for testing. The testing and actual production can co-exists with this logic.

The changes made in this PR allows for the is_test argument in several places. When passed, the outgoing messages are sent for this 2nd (test) cache, and subscribed channels are also for the test alert topic.

@KaraMelih KaraMelih closed this Aug 16, 2024
@sybenzvi
Copy link
Contributor

Disabled MacOS 12 (Monterrey) and 13 (Ventura) in the buildbot. Technically we should figure out how to make snews_pt work with Ventura b/c it's still under development. Support for Monterrey can be dropped.

Copy link
Contributor

@sybenzvi sybenzvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll make a separate ticket to check compatibility with Mac OS 13 (Ventura).

@sybenzvi sybenzvi merged commit e513fb7 into main Aug 16, 2024
3 checks passed
@sybenzvi sybenzvi deleted the testing_logic branch August 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants