Internal testing logic #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal_testing_logic
|
I turned off tests that use snews_pt for now. Once the snews_pt branch is merged, the packages will become compatible, then we can add it back |
sybenzvi
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
The snews_format_checker will disappear with @justinvasel's updates after this merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new setting allows for testing the coincidence system without interrupting the main coincidence cache.
The main change is that now there is a second cache for testing that runs parallel to the main one.
Everytime there is a new message in the stream, code checks if it is tagged with "is_test=True" and the test messages are recorded to this new cache. The coincidence search logic then is the same as the regular cache.
Once a coincidence is found within the test cache the alert is generated with "TEST" label, false-alarm rate calculations are bypassed, and the alert is sent out to the test connection topic which is also used for testing the connection.
The user can use the latest version of snews_pt to subscribe to these tests (SNEWS2/SNEWS_Publishing_Tools#120)
snews_pt subscribe --testor subscribe to the regular alertssnews_pt subscribeThis, in principle, eliminates the need of firedrill/no firedrill topics and the relevant variables. However, for now they still exists. So the main cache/topics can be swapped with the firedrill versions while the test topic always lives. It always reads from the either firedrill/nofiredrill observation topics, but always alerts the test connection topic.