Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: email bridge #33160

Merged
merged 8 commits into from
Sep 2, 2024
Merged

feat: email bridge #33160

merged 8 commits into from
Sep 2, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Aug 26, 2024

Proposed changes (including videos or screenshots)

Implement a new bridge that allow apps to send email using the SMTP server configured for the RC application.

Issue(s)

Steps to test or reproduce

Further comments

Depends on RocketChat/Rocket.Chat.Apps-engine#790
SCI-50

Copy link
Contributor

dionisio-bot bot commented Aug 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: e4311f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (037128c) to head (e4311f3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33160   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2546     2546           
  Lines        63242    63242           
  Branches     14217    14217           
========================================
  Hits         37525    37525           
  Misses       23015    23015           
  Partials      2702     2702           
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael changed the title feat: implement email bridge feat: email bridge Aug 27, 2024
@tapiarafael tapiarafael marked this pull request as ready for review August 27, 2024 16:51
@tapiarafael tapiarafael requested review from a team as code owners August 27, 2024 16:51
@MarcosSpessatto MarcosSpessatto added this to the 6.13 milestone Aug 28, 2024
@casalsgh casalsgh added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 2, 2024
@casalsgh
Copy link
Contributor

casalsgh commented Sep 2, 2024

Marked as QA assured as per message on project thread related to PR reviews.

@kodiakhq kodiakhq bot merged commit 8338807 into develop Sep 2, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/smtp-bridge branch September 2, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants