Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Otp email bridge #32982

Closed
wants to merge 4 commits into from
Closed

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Aug 5, 2024

Proposed changes (including videos or screenshots)

The following bridge will enable our apps to send OTP codes through the configured SMTP server

Issue(s)

Steps to test or reproduce

Further comments

SCI-50

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 50099d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/models Minor
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/instance-status Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 54.88%. Comparing base (a0ad916) to head (333901b).
Report is 33 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32982      +/-   ##
===========================================
- Coverage    55.67%   54.88%   -0.79%     
===========================================
  Files         2637     2599      -38     
  Lines        57399    56235    -1164     
  Branches     11892    11671     -221     
===========================================
- Hits         31956    30865    -1091     
  Misses       22730    22730              
+ Partials      2713     2640      -73     
Flag Coverage Δ
unit 72.30% <29.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael changed the base branch from develop to feat/create-contact-endpoint August 22, 2024 21:24
@tapiarafael tapiarafael changed the base branch from feat/create-contact-endpoint to feat/update-contact-endpoint August 22, 2024 21:25
@tapiarafael tapiarafael changed the base branch from feat/update-contact-endpoint to feat/unknown-contacts August 22, 2024 21:26
@tapiarafael
Copy link
Member

#33160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants