Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT][OCCHAB] add default mapping #3127

Open
wants to merge 2 commits into
base: feat/import
Choose a base branch
from

Conversation

jacquesfize
Copy link
Contributor

This PR propose to include new mapping dedicated to the OccHab destination.

@bouttier bouttier force-pushed the feat/import-add-default-mapping branch from 786a656 to f861f43 Compare August 14, 2024 14:03
Copy link
Contributor

@bouttier bouttier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de modèles dans les migrations !

id_occhab_mapping = session.execute(
sa.insert(MappingTemplate)
.values(
label="OccHab GeoNature",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occhab

id_mapping_sinp = session.execute(
sa.insert(MappingTemplate)
.values(
label="Données Habitats SINP",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je capte pas bien à quoi correspond cet autre mapping ?
Mais de ce que je comprends, il faudrait plutôt le nommer "Occurrences d'habitats SINP" ?

Copy link
Contributor

@bouttier bouttier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En sois OK mais plus simple de récupérer les tables par réflexivitées

@@ -8,9 +8,12 @@

import warnings
from alembic import op
from geonature.core.imports.models import Destination, FieldMapping, MappingTemplate
from geonature.core.imports.models import Destination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from geonature.core.imports.models import Destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: En revue
Development

Successfully merging this pull request may close these issues.

3 participants